LGTM
http://codereview.chromium.org/40011/diff/1/3 File src/d8-debug.cc (right): http://codereview.chromium.org/40011/diff/1/3#newcode270 Line 270: String::Utf8Value str(details->Get(String::New("text"))); Will this always succeed? If it can potentially fail, you should make sure to guard 'printf("%s\n", *str)' with a null check on str. (GCC optimizes printf("%s\n", ...) to puts(...) which cannot handle being passed a null pointer). http://codereview.chromium.org/40011/diff/1/3#newcode288 Line 288: Shell::ReportException(&try_catch); Indentation. http://codereview.chromium.org/40011/diff/1/5 File src/d8-debug.h (right): http://codereview.chromium.org/40011/diff/1/5#newcode85 Line 85: // Linked list of events from debugged V8 and form keyboard input. Access to form -> from http://codereview.chromium.org/40011/diff/1/5#newcode100 Line 100: explicit ReceiverThread(RemoteDebugger* remote_debugger) : I think we normally put the ':' on the next line and use a four-space indent? http://codereview.chromium.org/40011 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
