LGTM On Thu, Mar 5, 2009 at 8:45 AM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Description: > Merge revision 1422 from bleeding_edge to trunk making > this V8 version 1.0.3.5. > > Please review this at http://codereview.chromium.org/39178 > > SVN Base: http://v8.googlecode.com/svn/trunk/ > > Affected files: > M src/api.cc > M src/heap.cc > > > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 1421) > +++ src/api.cc (working copy) > @@ -2185,7 +2185,7 @@ > > > const char* v8::V8::GetVersion() { > - return "1.0.3.4"; > + return "1.0.3.5"; > } > > > Index: src/heap.cc > =================================================================== > --- src/heap.cc (revision 1421) > +++ src/heap.cc (working copy) > @@ -295,11 +295,15 @@ > > > void Heap::CollectAllGarbageIfContextDisposed() { > - if (context_disposed_pending_) { > + // If the garbage collector interface is exposed through the global > + // gc() function, we avoid being clever about forcing GCs when > + // contexts are disposed and leave it to the embedder to make > + // informed decisions about when to force a collection. > + if (!FLAG_expose_gc && context_disposed_pending_) { > StatsRateScope scope(&Counters::gc_context); > CollectAllGarbage(); > - context_disposed_pending_ = false; > } > + context_disposed_pending_ = false; > } > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
