Updated the CL to move the debugger related global variables from Top to thread local in Debug.
Ivan, please take another look. On 2009/03/05 16:11:23, Søren Gjesse wrote: > http://codereview.chromium.org/39124/diff/19/1003 > File src/debug.h (right): > http://codereview.chromium.org/39124/diff/19/1003#newcode361 > Line 361: // Preemption happened while debugging > On 2009/03/05 09:42:51, Erik Corry wrote: > > full stop > Done. > http://codereview.chromium.org/39124/diff/19/1003#newcode553 > Line 553: // Make sure that premption does not occour while handling the break > point. > On 2009/03/05 09:42:51, Erik Corry wrote: > > Spolling in too places. > Done. > http://codereview.chromium.org/39124/diff/19/1003#newcode559 > Line 559: } > On 2009/03/05 09:42:51, Erik Corry wrote: > > Seems like this part is not needed. If a preemption is pending then it will > hit > > immediately JS is resumed and it will set the preemption pending flag in > > execution.cc. > Without this I have seen some severe starvation when having two threads running > with preemption and one of them having a break point http://codereview.chromium.org/39124 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
