LGTM, but how about running the presubmit script :-)
http://codereview.chromium.org/40166/diff/1/9 File src/factory.h (right): http://codereview.chromium.org/40166/diff/1/9#newcode185 Line 185: // JS Global objects are pretenured. Global -> global http://codereview.chromium.org/40166/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/40166/diff/1/2#newcode1898 Line 1898: if (!result->IsFailure()) { Do you need the failure check? Isn't it allowed to call IsJSGlobalObject on a failure and doesn't it return false? http://codereview.chromium.org/40166/diff/1/2#newcode1907 Line 1907: // Make sure no field properties are described in the inital map. inital -> initial http://codereview.chromium.org/40166/diff/1/2#newcode1908 Line 1908: // This guarantee us that normalizing the properties does not guarantee -> guarantees http://codereview.chromium.org/40166/diff/1/6 File src/ic.cc (right): http://codereview.chromium.org/40166/diff/1/6#newcode455 Line 455: ? http://codereview.chromium.org/40166 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
