LGTM On Fri, Mar 6, 2009 at 10:55 AM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Description: > Fixed ARM build by remembering to apply object literal optimazation to > ARM code. > > Please review this at http://codereview.chromium.org/40214 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/codegen-arm.cc > > > Index: src/codegen-arm.cc > =================================================================== > --- src/codegen-arm.cc (revision 1431) > +++ src/codegen-arm.cc (working copy) > @@ -2688,6 +2688,8 @@ > Expression* value = property->value(); > switch (property->kind()) { > case ObjectLiteral::Property::CONSTANT: break; > + case ObjectLiteral::Property::OBJECT_LITERAL: > + if (property->value()->AsObjectLiteral()->is_simple()) break; > case ObjectLiteral::Property::COMPUTED: // fall through > case ObjectLiteral::Property::PROTOTYPE: { > frame_->EmitPush(r0); // dup the result > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
