Reviewers: Kasper Lund, Description: Fixed bug introduced in my last commit. I forgot to update the property details in SetNormalizedProperty.
Please review this at http://codereview.chromium.org/39332 SVN Base: http://v8.googlecode.com/svn/branches/experimental/global/ Affected files: M src/objects.cc Index: src/objects.cc =================================================================== --- src/objects.cc (revision 1446) +++ src/objects.cc (working copy) @@ -455,7 +455,8 @@ JSGlobalPropertyCell* cell = JSGlobalPropertyCell::cast(property_dictionary()->ValueAt(entry)); cell->set_value(value); - // No need to update the property dictionary. + // Please note we have to update the property details. + property_dictionary()->SetStringEntry(entry, name, cell, details); } else { property_dictionary()->SetStringEntry(entry, name, value, details); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
