Addressed comments, added regression test. The regression test takes 30 seconds in debug mode, but cannot be made much faster - a mark-sweep garbage collection is required.
http://codereview.chromium.org/40218/diff/1/6 File src/factory.cc (left): http://codereview.chromium.org/40218/diff/1/6#oldcode18 Line 18: // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR On 2009/03/06 12:25:28, Mads Ager wrote: > Whoops? Done. http://codereview.chromium.org/40218/diff/1/6 File src/factory.cc (right): http://codereview.chromium.org/40218/diff/1/6#newcode539 Line 539: w.WriteFrom(&r); On 2009/03/06 12:29:13, Kasper Lund wrote: > Weird indentation. Done. http://codereview.chromium.org/40218/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/40218/diff/1/3#newcode5653 Line 5653: details.type() != NULL_DESCRIPTOR && On 2009/03/06 12:25:28, Mads Ager wrote: > I guess you can use !r.IsNullDescriptor() here? Replaced by IsProperty() http://codereview.chromium.org/40218 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
