Reviewers: Mads Ager, Message: For the debugger in the Chrome developer tools the concept of a script id will make the handling of source much simpler. Also in general providing a debugger with the ability to handle the scripts added through their ids - and not rely on names which can easily be duplicated - makes much more sense.
Description: Whenever a script object is created it is assigned a unique id. Currently this id is assigned from an 32 bit integer counter. Changed the script break points to be able to handle both break points based on script names and script ids. When break points are set through a script id the position is relative to the script itself. This is different from the script break points set through script names where the line/coulmn offset is taken into account. This has the side effect that function break points are not converted into script break points for named scripts. Show the script id in the D8 shell debugger when listing all scripts using the 'scripts' command. Please review this at http://codereview.chromium.org/40317 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M include/v8.h M src/accessors.h M src/accessors.cc M src/api.cc M src/bootstrapper.cc M src/d8.js M src/debug-delay.js M src/factory.h M src/factory.cc M src/mirror-delay.js M src/objects-inl.h M src/objects.h M test/cctest/test-debug.cc M test/mjsunit/debug-script-breakpoints.js M test/mjsunit/debug-setbreakpoint.js --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
