I think this will work.

My only concern is the "...hidden..."; but I think you already plan to
address that separately.


http://codereview.chromium.org/40324/diff/1/4
File src/api.cc (right):

http://codereview.chromium.org/40324/diff/1/4#newcode1920
Line 1920: static_cast<PropertyAttributes>(None));
use ReadOnly?

http://codereview.chromium.org/40324/diff/1/6
File src/objects.cc (right):

http://codereview.chromium.org/40324/diff/1/6#newcode5079
Line 5079: return this->SetProperty(key, obj, DONT_ENUM);
DONT_ENUM | READ_ONLY ?

http://codereview.chromium.org/40324

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to