LGTM when Kevin's comments are addressed plus some more comments. Also what is the impact on compilation time and benchmark scores on top of the code bloat question in the comments?
Thanks, -Ivan http://codereview.chromium.org/42006/diff/1/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/42006/diff/1/3#newcode729 Line 729: ModeBits::encode(mode_) | I know this is not yours, but this looks like broken indentation. Thanks! http://codereview.chromium.org/42006/diff/1/3#newcode960 Line 960: SMI_CODE_INLINED); Since this code is now generated even if not in a loop in certain situations (e.g. reversed constant smi bitops), do you have measured the impact on code bloat? http://codereview.chromium.org/42006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
