If you deal with the virtual Initialize invocation in the JumpTarget constructor, this LGTM.
Cheers, Kasper On Wed, Mar 11, 2009 at 6:50 AM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Message: > Now ported to ARM (as much as was necessary). > > Description: > Fix issue 265 by handling extra statement state on the frame based on > the expectation at the break, continue, and return labels (including > shadowed ones) instead of based on the AST nodes. > > See http://code.google.com/p/v8/issues/detail?id=265 > > > Please review this at http://codereview.chromium.org/42017 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/assembler-arm.h > M src/assembler-ia32.h > M src/ast.h > M src/codegen-arm.h > M src/codegen-arm.cc > M src/codegen-ia32.h > M src/codegen-ia32.cc > M src/jump-target.h > M src/jump-target.cc > M src/virtual-frame-arm.h > M src/virtual-frame-arm.cc > M src/virtual-frame-ia32.h > M src/virtual-frame-ia32.cc > M src/virtual-frame.cc > D test/mjsunit/bugs/bug-265.js > M test/mjsunit/mjsunit.status > A test/mjsunit/regress/regress-265.js > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
