Yes, I should. I'll do that and then submit. On Wed, Mar 11, 2009 at 3:25 PM, Kasper Lund <[email protected]> wrote: > LGTM. Maybe you should add a BUG(271) marker to the two C++ tests that > you've now made "non-threaded"? > > On Wed, Mar 11, 2009 at 3:23 PM, <[email protected]> wrote: >> Reviewers: Kasper Lund, iposva, >> >> Description: >> Temporarily disable tests that no longer work on the ARM simulator. >> >> Exclude the tests from the threaded tests because I don't want to >> disable those on ARM. >> >> The issue is that the simulator keeps the C++ and the JavaScript stack >> separated. This is not a problem on the real hardware and the tests >> pass on our ARM box. >> >> Please review this at http://codereview.chromium.org/42069 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M test/cctest/cctest.status >> M test/cctest/test-api.cc >> >> >> Index: test/cctest/test-api.cc >> =================================================================== >> --- test/cctest/test-api.cc (revision 1487) >> +++ test/cctest/test-api.cc (working copy) >> @@ -1760,7 +1760,7 @@ >> >> // Test that a try-finally block doesn't shadow a try-catch block >> // when setting up an external handler. >> -THREADED_TEST(TryCatchInTryFinally) { >> +TEST(TryCatchInTryFinally) { >> v8::HandleScope scope; >> Local<ObjectTemplate> templ = ObjectTemplate::New(); >> templ->Set(v8_str("CCatcher"), >> @@ -1913,7 +1913,7 @@ >> // Each entry is an activation, either JS or C. The index is the count at >> that >> // level. Stars identify activations with exception handlers, the @ >> identifies >> // the exception handler that should catch the exception. >> -THREADED_TEST(ExceptionOrder) { >> +TEST(ExceptionOrder) { >> v8::HandleScope scope; >> Local<ObjectTemplate> templ = ObjectTemplate::New(); >> templ->Set(v8_str("check"), v8::FunctionTemplate::New(JSCheck)); >> Index: test/cctest/cctest.status >> =================================================================== >> --- test/cctest/cctest.status (revision 1483) >> +++ test/cctest/cctest.status (working copy) >> @@ -39,3 +39,11 @@ >> >> # BUG(240): Test seems flaky on ARM. >> test-api/RegExpInterruption: SKIP >> + >> +# BUG(271): After exception propagation changes that compares pointers >> +# into the stack, these tests fail on the arm simulator (but pass on >> +# the arm hardware) because the JS stack is not combined with the C >> +# stack in the simulator. Disabling while we consider how to solve >> +# the issue for the simulator. >> +test-api/ExceptionOrder: PASS || FAIL >> +test-api/TryCatchInTryFinally: PASS || FAIL >> >> >> >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
