Does it lint? Lgtm.
http://codereview.chromium.org/43073/diff/1/2 File tools/run-valgrind.py (right): http://codereview.chromium.org/43073/diff/1/2#newcode1 Line 1: #!/usr/bin/python Copyright? http://codereview.chromium.org/43073/diff/1/2#newcode34 Line 34: " possibly lost: \d+ bytes in \d+ blocks.") Any reason not to use r"(?:definitely|indirectly|possibly) lost:...". http://codereview.chromium.org/43073/diff/1/2#newcode37 Line 37: for line in errors: Simpler might be to use re.findall. http://codereview.chromium.org/43073 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
