2009/3/15  <[email protected]>:
> LGTM, thanks Erik!
>
>
> http://codereview.chromium.org/46088/diff/1/2
> File test/mjsunit/regress/regress-279.js (right):
>
> http://codereview.chromium.org/46088/diff/1/2#newcode29
> Line 29: return { foo: [] };
> Please add a test case for a nested object literal that you modify:
>
>  { bar: {} };
>
> as well as an object literal nested in an array literal:
>
>  [ {} ];
>
> http://codereview.chromium.org/46088
>

I added those two tests and I had to back out 1432 and 1433 too to
make them pass.


-- 
Erik Corry, Software Engineer
Google Denmark ApS.  CVR nr. 28 86 69 84
c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
Copenhagen K, Denmark.

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to