Reviewers: Søren Gjesse, Description: Fixed some memory leaks in unit tests.
Please review this at http://codereview.chromium.org/46103 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-api.cc M test/cctest/test-ast.cc M test/cctest/test-strings.cc M test/cctest/test-utils.cc Index: test/cctest/test-ast.cc =================================================================== --- test/cctest/test-ast.cc (revision 1514) +++ test/cctest/test-ast.cc (working copy) @@ -53,6 +53,7 @@ list->Clear(); CHECK_EQ(0, list->length()); + delete list; } Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (revision 1514) +++ test/cctest/test-api.cc (working copy) @@ -117,6 +117,7 @@ gate_(v8::internal::OS::CreateSemaphore(0)), active_(true) { } + ~ApiTestFuzzer() { delete gate_; } // The ApiTestFuzzer is also a Thread, so it has a Run method. virtual void Run(); @@ -5566,14 +5567,14 @@ // Add more than 8 (see kMaxFastProperties) properties // so that the constructor will force copying map. // Cannot sprintf, gcc complains unsafety. - char buf[5]; + char buf[4]; for (char i = '0'; i <= '9' ; i++) { - buf[1] = i; + buf[0] = i; for (char j = '0'; j <= '9'; j++) { - buf[2] = j; + buf[1] = j; for (char k = '0'; k <= '9'; k++) { - buf[3] = k; - buf[4] = 0; + buf[2] = k; + buf[3] = 0; templ->Set(v8_str(buf), v8::Number::New(k)); } } @@ -5621,6 +5622,7 @@ v8::ScriptData *sd = v8::ScriptData::PreCompile(script, strlen(script)); CHECK_NE(sd->Length(), 0); CHECK_NE(sd->Data(), NULL); + delete sd; } @@ -5702,6 +5704,8 @@ CHECK(regexp_success_); CHECK(gc_success_); } + RegExpInterruptTest() : block_(NULL) {} + ~RegExpInterruptTest() { delete block_; } private: // Number of garbage collections required. static const int kRequiredGCs = 5; Index: test/cctest/test-strings.cc =================================================================== --- test/cctest/test-strings.cc (revision 1514) +++ test/cctest/test-strings.cc (working copy) @@ -117,6 +117,7 @@ StringShape shape(*building_blocks[i]); CHECK_EQ(buf[j], building_blocks[i]->Get(shape, j)); } + DeleteArray<char>(buf); break; } } @@ -364,6 +365,7 @@ for (int i = 0; i < 500; i++) { TraverseFirst(flat_string, string, DEEP_ASCII_DEPTH); } + DeleteArray<char>(foo); } Index: test/cctest/test-utils.cc =================================================================== --- test/cctest/test-utils.cc (revision 1514) +++ test/cctest/test-utils.cc (working copy) @@ -174,5 +174,6 @@ } else { CHECK_EQ(length, strlen(buffer.start())); } + buffer.Dispose(); } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
