[v8-dev] [v8 commit] r1516 - Fixed some memory leaks in unit tests.

[codesite-noreply]

Author: olehougaard
Date: Mon Mar 16 00:53:20 2009
New Revision: 1516

Modified:
    branches/bleeding_edge/test/cctest/test-api.cc
    branches/bleeding_edge/test/cctest/test-ast.cc
    branches/bleeding_edge/test/cctest/test-strings.cc
    branches/bleeding_edge/test/cctest/test-utils.cc

Log:
Fixed some memory leaks in unit tests.
Review URL: http://codereview.chromium.org/46103

Modified: branches/bleeding_edge/test/cctest/test-api.cc
==============================================================================
--- branches/bleeding_edge/test/cctest/test-api.cc      (original)
+++ branches/bleeding_edge/test/cctest/test-api.cc      Mon Mar 16 00:53:20 2009
@@ -117,6 +117,7 @@
          gate_(v8::internal::OS::CreateSemaphore(0)),
          active_(true) {
    }
+  ~ApiTestFuzzer() { delete gate_; }

    // The ApiTestFuzzer is also a Thread, so it has a Run method.
    virtual void Run();
@@ -5566,14 +5567,14 @@
    // Add more than 8 (see kMaxFastProperties) properties
    // so that the constructor will force copying map.
    // Cannot sprintf, gcc complains unsafety.
-  char buf[5];
+  char buf[4];
    for (char i = '0'; i <= '9' ; i++) {
-    buf[1] = i;
+    buf[0] = i;
      for (char j = '0'; j <= '9'; j++) {
-      buf[2] = j;
+      buf[1] = j;
        for (char k = '0'; k <= '9'; k++) {
-        buf[3] = k;
-        buf[4] = 0;
+        buf[2] = k;
+        buf[3] = 0;
          templ->Set(v8_str(buf), v8::Number::New(k));
        }
      }
@@ -5621,6 +5622,7 @@
    v8::ScriptData *sd = v8::ScriptData::PreCompile(script, strlen(script));
    CHECK_NE(sd->Length(), 0);
    CHECK_NE(sd->Data(), NULL);
+  delete sd;
  }


@@ -5702,6 +5704,8 @@
      CHECK(regexp_success_);
      CHECK(gc_success_);
    }
+  RegExpInterruptTest() : block_(NULL) {}
+  ~RegExpInterruptTest() { delete block_; }
   private:
    // Number of garbage collections required.
    static const int kRequiredGCs = 5;

Modified: branches/bleeding_edge/test/cctest/test-ast.cc
==============================================================================
--- branches/bleeding_edge/test/cctest/test-ast.cc      (original)
+++ branches/bleeding_edge/test/cctest/test-ast.cc      Mon Mar 16 00:53:20 2009
@@ -53,6 +53,7 @@

    list->Clear();
    CHECK_EQ(0, list->length());
+  delete list;
  }



Modified: branches/bleeding_edge/test/cctest/test-strings.cc
==============================================================================
--- branches/bleeding_edge/test/cctest/test-strings.cc  (original)
+++ branches/bleeding_edge/test/cctest/test-strings.cc  Mon Mar 16 00:53:20  
2009
@@ -117,6 +117,7 @@
            StringShape shape(*building_blocks[i]);
            CHECK_EQ(buf[j], building_blocks[i]->Get(shape, j));
          }
+        DeleteArray<char>(buf);
          break;
        }
      }
@@ -364,6 +365,7 @@
    for (int i = 0; i < 500; i++) {
      TraverseFirst(flat_string, string, DEEP_ASCII_DEPTH);
    }
+  DeleteArray<char>(foo);
  }



Modified: branches/bleeding_edge/test/cctest/test-utils.cc
==============================================================================
--- branches/bleeding_edge/test/cctest/test-utils.cc    (original)
+++ branches/bleeding_edge/test/cctest/test-utils.cc    Mon Mar 16 00:53:20  
2009
@@ -174,5 +174,6 @@
      } else {
        CHECK_EQ(length, strlen(buffer.start()));
      }
+    buffer.Dispose();
    }
  }

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---