2009/3/17 Kasper Lund <[email protected]>: > > LGTM, but it might be nice to have some of the type testers directly > on the strings, so instead of always doing stuff like > StringShape(*string).IsSequential() it would be much better with > string->IsSequential().
I definitely want to do that, but this patch is so big already... > > 2009/3/16 <[email protected]>: >> Reviewers: Kasper Lund, >> >> Description: >> Remove all uses of StringShape variables, since that has proven >> to be error-prone and of little benefit in terms of performance. >> >> Please review this at http://codereview.chromium.org/45010 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/api.cc >> M src/codegen.cc >> M src/conversions.cc >> M src/factory.h >> M src/factory.cc >> M src/handles.cc >> M src/heap.h >> M src/heap.cc >> M src/interpreter-irregexp.cc >> M src/jsregexp.h >> M src/jsregexp.cc >> M src/log.cc >> M src/objects-debug.cc >> M src/objects-inl.h >> M src/objects.h >> M src/objects.cc >> M src/parser.cc >> M src/prettyprinter.cc >> M src/regexp-macro-assembler-ia32.cc >> M src/runtime.cc >> M test/cctest/test-heap.cc >> M test/cctest/test-regexp.cc >> M test/cctest/test-strings.cc >> >> >> > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
