LGTM
http://codereview.chromium.org/48123/diff/1/5 File src/platform-linux.cc (right): http://codereview.chromium.org/48123/diff/1/5#newcode612 Line 612: // Split timeout into seconds and nanoseconds parts. seconds and nanoseconds -> second and nanosecond http://codereview.chromium.org/48123/diff/1/5#newcode622 Line 622: // Calculate realtime for end of timeout. real time twowords. http://codereview.chromium.org/48123/diff/1/7 File src/platform.h (right): http://codereview.chromium.org/48123/diff/1/7#newcode420 Line 420: // true is returned. The timeout value is specified in miiliseconds. I would prefer microseconds. http://codereview.chromium.org/48123/diff/1/2 File test/cctest/test-lock.cc (right): http://codereview.chromium.org/48123/diff/1/2#newcode48 Line 48: ok = sem->Wait(1000); Please reduce the length of this wait so the tests continue to run fast. http://codereview.chromium.org/48123 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
