Reviewers: William Hesse, Description: Fixed memory leaks in socket implementation.
Fixed memory leaks reported by valgring in the socket implementation and socket tests. BUG=276 Please review this at http://codereview.chromium.org/42331 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/platform-freebsd.cc M src/platform-linux.cc M src/platform-macos.cc M src/platform-win32.cc M test/cctest/test-sockets.cc Index: test/cctest/test-sockets.cc =================================================================== --- test/cctest/test-sockets.cc (revision 1534) +++ test/cctest/test-sockets.cc (working copy) @@ -22,6 +22,8 @@ // Close both sockets. delete client_; delete server_; + delete listening_; + delete[] data_; } void Run(); @@ -127,6 +129,7 @@ medium_data[i] = i % 256; } SendAndReceive(medium_data, kBufferSizeMedium); + delete[] medium_data; // Send and receive even more data. static const int kBufferSizeLarge = 1000000; @@ -135,6 +138,7 @@ large_data[i] = i % 256; } SendAndReceive(large_data, kBufferSizeLarge); + delete[] large_data; } Index: src/platform-freebsd.cc =================================================================== --- src/platform-freebsd.cc (revision 1534) +++ src/platform-freebsd.cc (working copy) @@ -738,6 +738,7 @@ // Connect. status = connect(socket_, result->ai_addr, result->ai_addrlen); + freeaddrinfo(result); return status == 0; } Index: src/platform-win32.cc =================================================================== --- src/platform-win32.cc (revision 1534) +++ src/platform-win32.cc (working copy) @@ -1636,6 +1636,7 @@ // Connect. status = connect(socket_, result->ai_addr, result->ai_addrlen); + freeaddrinfo(result); return status == 0; } Index: src/platform-linux.cc =================================================================== --- src/platform-linux.cc (revision 1534) +++ src/platform-linux.cc (working copy) @@ -739,6 +739,7 @@ // Connect. status = connect(socket_, result->ai_addr, result->ai_addrlen); + freeaddrinfo(result); return status == 0; } Index: src/platform-macos.cc =================================================================== --- src/platform-macos.cc (revision 1534) +++ src/platform-macos.cc (working copy) @@ -670,6 +670,7 @@ // Connect. status = connect(socket_, result->ai_addr, result->ai_addrlen); + freeaddrinfo(result); return status == 0; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
