Reviewers: Mike Belshe, Description: Minor build and code style issues.
Please review this at http://codereview.chromium.org/42354 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/handles.cc M test/cctest/test-api.cc Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (revision 1540) +++ test/cctest/test-api.cc (working copy) @@ -5810,7 +5810,7 @@ v8::HandleScope scope; LocalContext env; - char* sample = + const char* sample = "var rv = {};" \ "rv.alpha = 'hello';" \ "rv.beta = 123;" \ @@ -5837,4 +5837,3 @@ CHECK_EQ(v8::Integer::New(123), obj->Get(v8_str("beta"))); CHECK_EQ(v8::Integer::New(456), clone->Get(v8_str("beta"))); } - Index: src/handles.cc =================================================================== --- src/handles.cc (revision 1540) +++ src/handles.cc (working copy) @@ -72,7 +72,7 @@ current_.limit = limit; } } - + // If we still haven't found a slot for the handle, we extend the // current handle scope by allocating a new handle block. if (result == current_.limit) { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
