Mike, why do you want to turn off profiling in release builds. With this change it is no longer possible to use the V8 profiler for e.g. test_shell, right? How much does the v8::internal::Logger::is_enabled() check cost when the not active. Maybe we should split regular logging calls and profiling calls? /Søren
On Fri, Mar 20, 2009 at 1:32 AM, <[email protected]> wrote: > > Reviewers: davemoore, > > Description: > Reluctantly turn off the debug flags in optimized builds. > Beware, this may unexpectedly improve performance. > > > Please review this at http://codereview.chromium.org/50043 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M tools/visual_studio/common.vsprops > > > Index: tools/visual_studio/common.vsprops > =================================================================== > --- tools/visual_studio/common.vsprops (revision 1555) > +++ tools/visual_studio/common.vsprops (working copy) > @@ -10,7 +10,7 @@ > <Tool > Name="VCCLCompilerTool" > > > AdditionalIncludeDirectories="$(ProjectDir)\..\..\src;$(IntDir)\DerivedSources" > - > > PreprocessorDefinitions="WIN32;_CRT_SECURE_NO_DEPRECATE;_CRT_NONSTDC_NO_DEPRECATE;_USE_32BIT_TIME_T;_HAS_EXCEPTIONS=0;PCRE_STATIC;ENABLE_LOGGING_AND_PROFILING" > + > > PreprocessorDefinitions="WIN32;_CRT_SECURE_NO_DEPRECATE;_CRT_NONSTDC_NO_DEPRECATE;_USE_32BIT_TIME_T;_HAS_EXCEPTIONS=0;PCRE_STATIC" > MinimalRebuild="false" > ExceptionHandling="0" > RuntimeTypeInfo="false" > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
