Changed name, added ARM changes.
http://codereview.chromium.org/50012/diff/1/2 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/50012/diff/1/2#newcode525 Line 525: __ mov(backing_reg, Operand(ebp, fp_relative(index))); On 2009/03/19 15:45:52, Kevin Millikin wrote: > I think it's clearer to Use(backing_reg) just before or after this line rather > than unusing it in the register case and then calling use on it again in both > cases. That way, there is a single use on the memory case, and no unuse/use on > the register case. Done. http://codereview.chromium.org/50012/diff/1/2#newcode535 Line 535: new_backing_element.set_sync(); On 2009/03/19 15:45:52, Kevin Millikin wrote: > You might consider just putting the creation of the new element and assignment > to elements_[i] in this conditional (making it an if/else). If we're going to > test the sync flag, we might as well create it with the right one in the first > place. Done, and made much more direct - pass the sync value from elements_[i] to the constructor. Also optimized below - create an unsynced and a synced copy, rather than continually setting and unsetting the sync bit. http://codereview.chromium.org/50012 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
