LGTM 2009/3/20 <[email protected]>: > Reviewers: Erik Corry, > > Message: > Quick fix! > > Description: > Now compiles when not in debug mode. Whoops. > > Please review this at http://codereview.chromium.org/50054 > > Affected files: > M src/regexp-macro-assembler-ia32.cc > > > Index: src/regexp-macro-assembler-ia32.cc > diff --git a/src/regexp-macro-assembler-ia32.cc > b/src/regexp-macro-assembler-ia32.cc > index > ce452ce37ba52865e0fc35c5c2464aa36350863c..fa529a572b92de4b87adb865b4a937dc3a6ff0a3 > 100644 > --- a/src/regexp-macro-assembler-ia32.cc > +++ b/src/regexp-macro-assembler-ia32.cc > @@ -1109,7 +1109,7 @@ const byte* > RegExpMacroAssemblerIA32::StringCharacterPosition(String* subject, > ASSERT(start_index <= subject->length()); > if (StringShape(subject).IsAsciiRepresentation()) { > const byte* address; > - if (subject->IsExternalAsciiString()) { > + if (StringShape(subject).IsExternal()) { > const char* data = > ExternalAsciiString::cast(subject)->resource()->data(); > address = reinterpret_cast<const byte*>(data); > } else { > @@ -1120,7 +1120,7 @@ const byte* > RegExpMacroAssemblerIA32::StringCharacterPosition(String* subject, > return address + start_index; > } > const uc16* data; > - if (subject->IsExternalTwoByteString()) { > + if (StringShape(subject).IsExternal()) { > data = ExternalTwoByteString::cast(subject)->resource()->data(); > } else { > ASSERT(subject->IsSeqTwoByteString()); > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
