LGTM On Fri, Mar 20, 2009 at 4:33 PM, <[email protected]> wrote: > > Reviewers: Mads Ager, > > Message: > TBR = ager > > Description: > - Fix constness in tests. > > Please review this at http://codereview.chromium.org/42472 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M test/cctest/test-api.cc > > > Index: test/cctest/test-api.cc > =================================================================== > --- test/cctest/test-api.cc (revision 1568) > +++ test/cctest/test-api.cc (working copy) > @@ -1341,7 +1341,7 @@ > CHECK_EQ(x, 10); > > // Make sure unaligned pointers are wrapped properly. > - char* data = "0123456789"; > + char* data = strdup("0123456789"); > Local<v8::External> zero = v8::External::New(&data[0]); > Local<v8::External> one = v8::External::New(&data[1]); > Local<v8::External> two = v8::External::New(&data[2]); > @@ -1355,6 +1355,7 @@ > CHECK_EQ('2', *char_ptr); > char_ptr = reinterpret_cast<char*>(three->Value()); > CHECK_EQ('3', *char_ptr); > + free(data); > } > > > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
