LGTM! 2009/3/23 <[email protected]>: > Reviewers: Erik Corry, > > Message: > Review, please. > > Description: > Fix bug in regexp the breaks interpreter. > > Please review this at http://codereview.chromium.org/52006 > > Affected files: > M src/jsregexp.cc > > > Index: src/jsregexp.cc > diff --git a/src/jsregexp.cc b/src/jsregexp.cc > index > d3626f3a67b799473a264013bb8e0c8c8b7f9f31..e1171894335aebb5ef9a2079b67d814924512cf5 > 100644 > --- a/src/jsregexp.cc > +++ b/src/jsregexp.cc > @@ -617,6 +617,9 @@ Handle<Object> > RegExpImpl::IrregexpExecOnce(Handle<JSRegExp> jsregexp, > #endif > } else { > bool is_ascii = StringShape(*subject).IsAsciiRepresentation(); > + if (!EnsureCompiledIrregexp(jsregexp, is_ascii)) { > + return Handle<Object>::null(); > + } > for (int i = number_of_capture_registers - 1; i >= 0; i--) { > offsets_vector[i] = -1; > } > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
