LGTM. On Mon, Mar 23, 2009 at 10:39 AM, <[email protected]> wrote:
> > Reviewers: Kevin Millikin, > > Description: > Profiler ticks every 1ms instead of every 10ms. > > Please review this at http://codereview.chromium.org/42498 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/log.cc > > > Index: src/log.cc > =================================================================== > --- src/log.cc (revision 1572) > +++ src/log.cc (working copy) > @@ -1020,7 +1020,7 @@ > // as log is initialized early with V8, we can assume that JS execution > // frames can never reach this point on stack > int stack_var; > - ticker_ = new Ticker(10, reinterpret_cast<unsigned int>(&stack_var)); > + ticker_ = new Ticker(1, reinterpret_cast<unsigned int>(&stack_var)); > > if (FLAG_sliding_state_window && sliding_state_window_ == NULL) { > sliding_state_window_ = new SlidingStateWindow(); > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
