http://codereview.chromium.org/52010/diff/1/6 File SConstruct (right):
http://codereview.chromium.org/52010/diff/1/6#newcode37 Line 37: Please add a comment on where this TOP environment variable is used and for what purpose. Maybe rename it in the scons file to ANDROID_TOP. http://codereview.chromium.org/52010/diff/1/6#newcode296 Line 296: }, Isn't all this stuff required for building mksnapshot and the D8 shell as well? http://codereview.chromium.org/52010/diff/1/5 File src/execution.cc (right): http://codereview.chromium.org/52010/diff/1/5#newcode486 Line 486: Object* result = 0; 0 -> NULL. http://codereview.chromium.org/52010 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
