LGTM
http://codereview.chromium.org/52012/diff/1/11 File SConstruct (right): http://codereview.chromium.org/52012/diff/1/11#newcode41 Line 41: }, Oops! http://codereview.chromium.org/52012/diff/1/9 File src/debug-agent.cc (right): http://codereview.chromium.org/52012/diff/1/9#newcode301 Line 301: "Type: connect\n"); Normally if you have ASCII content on a socket it is sent with cr-lf. At least that's what HTTP does and what telnet expects. http://codereview.chromium.org/52012/diff/1/10 File src/debug-agent.h (right): http://codereview.chromium.org/52012/diff/1/10#newcode61 Line 61: SmartPointer<const char> name_; // Name of the embedding application. I'm not sure you can use a SmartPointer this way. They are pretty dumb you know. :-) Check out the copy constructor for example. I think this is the first time someone has tried to use one for a member variable. http://codereview.chromium.org/52012 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
