LGTM with bounds check stuff fixed.
http://codereview.chromium.org/42553/diff/1/2 File src/debug-agent.cc (right): http://codereview.chromium.org/42553/diff/1/2#newcode235 Line 235: ASSERT(header_buffer_position < kHeaderBufferSize); I don't see how you can assert this. You need a test that overflows the header buffer. http://codereview.chromium.org/42553/diff/1/2#newcode244 Line 244: for (int i = 0; i < header_buffer_position; i++) { I think it would be healthier if there was a break on header_buffer[i] == 0 instead of going past it. http://codereview.chromium.org/42553 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
