Try avoid using "pointer" for things that aren't C++ pointers. I have a few suggestions on identifier names and comments, otherwise LGTM.
http://codereview.chromium.org/53005/diff/1/2 File src/jump-target.cc (right): http://codereview.chromium.org/53005/diff/1/2#newcode275 Line 275: // Set the register counts and positions. Indices, not positions. http://codereview.chromium.org/53005/diff/1/2#newcode282 Line 282: if (current.is_register()) { else if? http://codereview.chromium.org/53005/diff/1/6 File src/virtual-frame-arm.h (right): http://codereview.chromium.org/53005/diff/1/6#newcode381 Line 381: // of updating a pointer to the register's location in the frame. "The index of" not "a pointer to". http://codereview.chromium.org/53005/diff/1/6#newcode386 Line 386: // pointer to the register's in the frame. "Index", not "pointer". To the register's what? http://codereview.chromium.org/53005/diff/1/4 File src/virtual-frame-ia32.h (right): http://codereview.chromium.org/53005/diff/1/4#newcode342 Line 342: int frame_location_[kNumRegisters]; frame_location_ is not a good name for the registers' indices in the frame. "register_indices_"? "register_locations_"? http://codereview.chromium.org/53005/diff/1/4#newcode380 Line 380: // of updating a pointer to the register's location in the frame. Index, not pointer. http://codereview.chromium.org/53005/diff/1/4#newcode385 Line 385: // pointer to the register's in the frame. Index, not pointer. The register's what? http://codereview.chromium.org/53005 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
