LGTM

This is great!


http://codereview.chromium.org/49028/diff/1/2
File src/platform-win32.cc (right):

http://codereview.chromium.org/49028/diff/1/2#newcode1818
Line 1818: if (IsProfiling()) {
I think the comment needs to be changed a bit as still says "duplicate
the handle". It could say "open an additional handle" and maybe mention
while DuplicateHandle is not used.

http://codereview.chromium.org/49028

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to