All recommended changes made.
http://codereview.chromium.org/42565/diff/1/2 File src/jump-target.cc (right): http://codereview.chromium.org/42565/diff/1/2#newcode275 Line 275: // Set the register counts and indices. On 2009/03/25 08:48:19, Kevin Millikin wrote: > Update this comment to go with the code. Done. http://codereview.chromium.org/42565/diff/1/6 File src/virtual-frame-arm.h (right): http://codereview.chromium.org/42565/diff/1/6#newcode80 Line 80: return frame_registers_.count(reg); On 2009/03/25 08:48:19, Kevin Millikin wrote: > You should remove this function and the RegisterFile from the ARM frame class. Done. http://codereview.chromium.org/42565/diff/1/5 File src/virtual-frame.cc (right): http://codereview.chromium.org/42565/diff/1/5#newcode196 Line 196: } else if (cgen_->allocator()->count(i) == 0) { On 2009/03/25 08:48:19, Kevin Millikin wrote: > The only call site of this function has already searched for unused registers, > so we don't need to repeat that work here. I think you should be able to skip > the else if and break out of the loop as soon as you find a register to spill. Yes, I think so to, but then this function has a precondition. I'll do it. Done. http://codereview.chromium.org/42565/diff/1/5#newcode387 Line 387: if (!is_used(value->reg())) { On 2009/03/25 08:48:19, Kevin Millikin wrote: > I like to flip these ifs with elses so the condition is not negated. I thought it was better to be able to quickly read about the free-register case, then worry about the bigger other case. But I can switch itl Done. http://codereview.chromium.org/42565/diff/1/5#newcode487 Line 487: new_element = CopyElementAt(register_index(reg)); On 2009/03/25 08:48:19, Kevin Millikin wrote: > You could consider just adding the copy to elements_ (and the register in the > other branch of the if) rather than assigning to a local and adding later. Done. http://codereview.chromium.org/42565 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
