On Wed, Mar 25, 2009 at 2:25 PM, <[email protected]> wrote: > LGTM. Maybe the register-pair-swapping could be generalized long term? >
Yeah. There are a few other places where we do exactly the same thing. I don't think we need to generalize it beyond two, either. http://codereview.chromium.org/42602/diff/1/5 > File src/codegen-ia32.cc (right): > > http://codereview.chromium.org/42602/diff/1/5#newcode5190 > Line 5190: ? RelocInfo::CODE_TARGET_CONTEXT > 4 space indent here? > I like my way better. http://codereview.chromium.org/42602/diff/1/2 > File src/virtual-frame-ia32.cc (right): > > http://codereview.chromium.org/42602/diff/1/2#newcode783 > Line 783: // name in ecx and reciever on the stack. It does not drop > the > reciever -> receiver (i before e except after c) > I thought we had a spellchecker :) --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
