This should be integrated with the changes made in revision 1621, where we moved away from recognition of Smis in the parsing or AST, and instead recognized compile-time constant Smis when they show up as constant results. Can we recognize string literals when they show up as constant results?
Would we catch more cases, or the same cases, if we spotted literal strings just because they become constant results? When one of the inputs to a binary operation is a constant, we check its type to see if it is a string. Constants are created by processing the Literal AST nodes. This will integrate better with the long-term plans, where information about the compile-time type of something will be part of the FrameElement and Result classes. http://codereview.chromium.org/42644 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
