LGTM.
http://codereview.chromium.org/42643/diff/6/1008 File src/debug.cc (right): http://codereview.chromium.org/42643/diff/6/1008#newcode1910 Line 1910: void Debugger::InvokeMessageHandler(Vector< uint16_t> message) { Remove space in Vector< uint16_t>? http://codereview.chromium.org/42643/diff/6/1008#newcode1919 Line 1919: // If there is not message thread just invoke the message handler from the not -> no http://codereview.chromium.org/42643/diff/6/1008#newcode1974 Line 1974: Vector<uint16_t>(const_cast<uint16_t *>(command.start()), remove space in "uint16_t *"? http://codereview.chromium.org/42643/diff/6/1008#newcode2007 Line 2007: // Send an empty command to the debugger if in a break to make JavaScript run This line looks too long. http://codereview.chromium.org/42643/diff/6/1008#newcode2062 Line 2062: DebugMessageThread::DebugMessageThread() { Just inline this in the header? http://codereview.chromium.org/42643/diff/6/1008#newcode2067 Line 2067: DebugMessageThread::~DebugMessageThread() { Ditto. http://codereview.chromium.org/42643/diff/6/1007 File src/debug.h (right): http://codereview.chromium.org/42643/diff/6/1007#newcode541 Line 541: static Semaphore* command_received_; // Non-zero when command queue is non-empty. The lines look too long. Put the comments on the line before the declaration? http://codereview.chromium.org/42643 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
