Putting a sleep into one test might not seem like a big deal, but with
the tests currently running in 10-12 seconds on a 4 core machine
(tools/test.py -j4) it just takes a few tests with this kind of sleep to
degrade that.

You yourself suggested to have the barrier in the JavaScript code as
well. I think that is a good idea. What you need to do is to have a
function in JavaScript that calls back into C++ to wait for the barrier.
You can take a look at CallFunctionInDebugger in test-debug.cc for one
example of how to do that or look at test-api.cc which have a lot of
different examples.


http://codereview.chromium.org/42686/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/42686/diff/1/2#newcode3383
Line 3383: OS::Sleep(1000);
Please find another way to fix this.

http://codereview.chromium.org/42686

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to