LGTM
http://codereview.chromium.org/42641/diff/3001/3005 File src/d8-posix.cc (right): http://codereview.chromium.org/42641/diff/3001/3005#newcode477 Line 477: if (!WaitForChild(pid, child_waiter, start_time, read_timeout, total_timeout)) { This line looks too long. http://codereview.chromium.org/42641/diff/3001/3003 File src/d8-windows.cc (right): http://codereview.chromium.org/42641/diff/3001/3003#newcode40 Line 40: ThrowException(String::New("system() is not yet supported on your OS")); Nit picking, but I don't like this indentation. How about: Handle<String> error_message = String::New("system() is not yet supported on your OS"); return ThrowException(error_message); http://codereview.chromium.org/42641 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
