On Mon, Mar 30, 2009 at 3:26 PM, <[email protected]> wrote: > LGTM > > I don't like having the macro all over the api implementation, but I > don't see how else to do this. >
Agreed. A lot of the API functions have dead checks, ensure initialized, and/or logging on entry. We might be able to combine some of that stuff and piggyback on it. > > > http://codereview.chromium.org/56060/diff/1/6 > File src/global-handles.cc (right): > > http://codereview.chromium.org/56060/diff/1/6#newcode157 > Line 157: { // Leaving V8. > This probably does not lint? > It does, but I'll just change it to match the other sites. > > > http://codereview.chromium.org/56060 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
