http://codereview.chromium.org/56064/diff/1/2 File src/log.cc (right):
http://codereview.chromium.org/56064/diff/1/2#newcode405 Line 405: OS::FSetMode(Logger::logfile_, false); I think we should try to avoid the file mode change (see comments in platform.h). http://codereview.chromium.org/56064/diff/1/2#newcode435 Line 435: msg.WriteCStringToLogFile(content); Will this still be required if we use binary file mode? http://codereview.chromium.org/56064/diff/1/6 File src/platform.h (right): http://codereview.chromium.org/56064/diff/1/6#newcode157 Line 157: static void FSetMode(FILE* stream, bool text_mode); I think we should try to avoid having this function. How about making sure that on windows "b" is added to the mode when performing fopen on Windows. That should avoid any translation when writing to files on Windows. Having just \n on Windows is preferable to adding this function and trying to control the file mode while writing. http://codereview.chromium.org/56064/diff/1/7 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/56064/diff/1/7#newcode828 Line 828: LOG(RegExpCodeCreateEvent("RegExp", *code, *source)); Is the first parameter required for this RegExp specific function? http://codereview.chromium.org/56064 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
