Reviewers: Kevin Millikin, Message: A petty code review for you to look at sometime.
Description: Keep the result of postfix increment and decrement in a register. Please review this at http://codereview.chromium.org/56106 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/codegen-ia32.cc Index: src/codegen-ia32.cc =================================================================== --- src/codegen-ia32.cc (revision 1649) +++ src/codegen-ia32.cc (working copy) @@ -4804,7 +4804,9 @@ // Postfix: Store the old value as the result. if (is_postfix) { - Result old_value = value; + Result old_value = allocator_->Allocate(); + ASSERT(old_value.is_valid()); + __ mov(old_value.reg(), value.reg()); frame_->SetElementAt(target.size(), &old_value); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
