http://codereview.chromium.org/56107/diff/1/5 File src/d8-posix.cc (right):
http://codereview.chromium.org/56107/diff/1/5#newcode587 Line 587: if (errno == EEXIST) { Is this is to handle from paths with '..' e.g. xxx/yyy/../yyy, or is it not supposed to happen? http://codereview.chromium.org/56107/diff/1/3 File src/d8-windows.cc (right): http://codereview.chromium.org/56107/diff/1/3#newcode39 Line 39: os_templ->Set(String::New("setenv"), FunctionTemplate::New(SetEnvironment)); Why did you leave setenv here? It is not implemented either. http://codereview.chromium.org/56107 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
