I don't think this should be a byte, rather than a word, unless you know how you plan to embed it in a word with some other shared info.
http://codereview.chromium.org/57052/diff/40/49 File src/register-allocator.h (right): http://codereview.chromium.org/57052/diff/40/49#newcode100 Line 100: STRING_TYPE = 12 Should you represent these values in hex: 0xC? Should these values be aligned, or have end-of-line comments instead? http://codereview.chromium.org/57052/diff/40/49#newcode105 Line 105: byte static_type_; We haven't really been using bytes in structures except as definite parts of words. Do we know what this does to alignment of everything else? http://codereview.chromium.org/57052/diff/40/49#newcode196 Line 196: If this ever did save memory, it would do so by totally messing up the alignment of everything following it. I'm suspicious. http://codereview.chromium.org/57052 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
