LGTM. Maybe change 'Revert' to 'Reverted' to match the other ChangeLog entries.
On Wed, Apr 1, 2009 at 12:37 PM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Description: > Prepare another push to trunk (version 1.1.6). We pushed an unsafe > compiler optimization which has now been reverted. > > Please review this at http://codereview.chromium.org/60011 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M ChangeLog > M src/api.cc > > > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 1661) > +++ src/api.cc (working copy) > @@ -2421,7 +2421,7 @@ > > > const char* v8::V8::GetVersion() { > - return "1.1.6 (candidate)"; > + return "1.1.7 (candidate)"; > } > > > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 1661) > +++ ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2009-04-01: Version 1.1.6 > + > + Revert an unsafe code generator change. > + > + > 2009-04-01: Version 1.1.5 > > Fixed bug that caused function literals to not be optimized as > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
