It seems plausible. LGTM.
http://codereview.chromium.org/60046/diff/1/2 File SConstruct (right): http://codereview.chromium.org/60046/diff/1/2#newcode511 Line 511: result.Add('importenv', 'import environment settings (NAME1,NAME2)', '') Might be clearer to have the message string: 'import environment settings (NAME1,NAME2,...)' Also, consider zero-based indexing. :) http://codereview.chromium.org/60046/diff/1/2#newcode632 Line 632: # The environment imports are in the format NAME1,NAME2 Analogously here. http://codereview.chromium.org/60046 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
