LGTM!

http://codereview.chromium.org/63010/diff/1/3
File src/objects.cc (right):

http://codereview.chromium.org/63010/diff/1/3#newcode5524
Line 5524: } else {
Perhaps add the comment "// Getter is not a function." (same as for the
named property case).

http://codereview.chromium.org/63010/diff/1/2
File test/mjsunit/indexed-accessors.js (right):

http://codereview.chromium.org/63010/diff/1/2#newcode117
Line 117: if(a|= ''){}
Please add space on both sides of the '('.

http://codereview.chromium.org/63010

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to