LGTM 2009/4/14 <[email protected]>: > Reviewers: Erik Corry, > > Description: > Remove definition of _HAS_EXCEPTIONS from source files. > > The define _HAS_EXCEPTIONS=0 is only required on Windows and is already > set in the SCons build file and Visual Studio project files. > > Please review this at http://codereview.chromium.org/67116 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M samples/process.cc > M src/mksnapshot.cc > > > Index: samples/process.cc > =================================================================== > --- samples/process.cc (revision 1693) > +++ samples/process.cc (working copy) > @@ -27,8 +27,6 @@ > > #include <v8.h> > > -// To avoid warnings from <map> on windows we disable exceptions. > -#define _HAS_EXCEPTIONS 0 > #include <string> > #include <map> > > Index: src/mksnapshot.cc > =================================================================== > --- src/mksnapshot.cc (revision 1693) > +++ src/mksnapshot.cc (working copy) > @@ -25,8 +25,6 @@ > // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > -// To avoid warnings from <map> on windows we disable exceptions. > -#define _HAS_EXCEPTIONS 0 > #include <signal.h> > #include <string> > #include <map> > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
