LGTM
http://codereview.chromium.org/65006/diff/1/2 File src/mirror-delay.js (right): http://codereview.chromium.org/65006/diff/1/2#newcode1718 Line 1718: // Add the handle for value mirrors. Change comment to "Add mirror handle" (script mirror is not a value mirror). http://codereview.chromium.org/65006/diff/1/2#newcode1778 Line 1778: if (mirror.id()) { This if should not be needed as all scripts have id. http://codereview.chromium.org/65006/diff/1/2#newcode1916 Line 1916: if (func.script()) { Please just add the script directly to the frame serialization to keep the the refs to be decendents of the serailized objects. if (func.script()) { content.push(MakeJSONPair_('script', this.serializeReference(mirror.func().script()))); } If we add the source to the script serialization this might be to expensive... http://codereview.chromium.org/65006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
