http://codereview.chromium.org/67151/diff/1/3 File test/mjsunit/tools/splaytree.js (right):
http://codereview.chromium.org/67151/diff/1/3#newcode28 Line 28: // Files: tools/splaytree.js On 2009/04/15 01:11:52, Søren Gjesse wrote: > Please add a comment that this is relative to the project root - I confused me > as I was at first thinking that the file was importing itself. Done. http://codereview.chromium.org/67151/diff/1/4 File tools/splaytree.js (right): http://codereview.chromium.org/67151/diff/1/4#newcode149 Line 149: goog.structs.SplayTree.prototype.findMin = function() { On 2009/04/15 01:11:52, Søren Gjesse wrote: > Maybe add opt_startNode to match findMax. This asymmetry exists because findGreatestLessThan doesn't have a mirror function. Unless we contribute this code to a JS library, I think this doesn't matter much. http://codereview.chromium.org/67151 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
