2009/4/15 <[email protected]>: > > http://codereview.chromium.org/67163/diff/1/11 > File src/codegen-arm.cc (right): > > http://codereview.chromium.org/67163/diff/1/11#newcode688 > Line 688: // Minor key encoding in 16 bits FOOOOOOOOOOOOOMM. > This comment is wrong. There is no "F" here.
FOOM removed since it added little to the comment + code already there. > http://codereview.chromium.org/67163/diff/1/11#newcode4550 > Line 4550: __ ldr(r2, MemOperand(r0, HeapNumber::kValueOffset - > kHeapObjectTag)); > On IA32 there is a FieldOperand abstraction (in macro-assembler-ia32.h) > that does the subtract kHeapObjectTag thing. You might consider the > same for ARm and using it here. Turns out we already had FieldMemOperand, which I used. -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
