LGTM

2009/4/16  <[email protected]>:
> Reviewers: Erik Corry,
>
> Description:
> Remove some unused macros from objects.cc.
>
> Please review this at http://codereview.chromium.org/67211
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected files:
>  M     src/objects.cc
>
>
> Index: src/objects.cc
> ===================================================================
> --- src/objects.cc      (revision 1720)
> +++ src/objects.cc      (working copy)
> @@ -43,22 +43,6 @@
>
>  namespace v8 { namespace internal {
>
> -#define FIELD_ADDR(p, offset) \
> -  (reinterpret_cast<byte*>(p) + offset - kHeapObjectTag)
> -
> -
> -#define WRITE_FIELD(p, offset, value) \
> -  (*reinterpret_cast<Object**>(FIELD_ADDR(p, offset)) = value)
> -
> -
> -#define WRITE_INT_FIELD(p, offset, value) \
> -  (*reinterpret_cast<int*>(FIELD_ADDR(p, offset)) = value)
> -
> -
> -#define WRITE_BARRIER(object, offset) \
> -  Heap::RecordWrite(object->address(), offset);
> -
> -
>  // Getters and setters are stored in a fixed array property.  These are
>  // constants for their indices.
>  const int kGetterIndex = 0;
>
>
>



-- 
Erik Corry, Software Engineer
Google Denmark ApS.  CVR nr. 28 86 69 84
c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
Copenhagen K, Denmark.

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to